search

strongloop / strong-pm

deployer for node applications
http://strong-pm.io
Other
1k stars 71 forks source link

use websocket channel for docker driver #237

Closed rmg closed 9 years ago

rmg commented 9 years ago

Connect to strongloop-internal/scrum-nodeops#582

rmg commented 9 years ago

@slnode test please

rmg commented 9 years ago

@sam-github this is the minimum change required to get Docker to support WS, but it does not include the changes to make it required and does not include any driver refactoring to reduce duplication of WS related code. Should I continue on this PR with those changes? Or review/merge this and continue on with a follow-up PR?

rmg commented 9 years ago

@slnode test please

sam-github commented 9 years ago

@rmg no preference, as you wish

kraman commented 9 years ago

Small nit about the public IP detection. Rest LGTM

rmg commented 9 years ago

@slnode test please

rmg commented 9 years ago

@kraman I rebased with note about the public IP. Does that address your comment well enough to merge?

BTW, b60125f737011f77f5bb8d657430e0c8a4603899 should cover pretty much all the changes you would need to make to central to switch it away from express-ws.

kraman commented 9 years ago

Lgtm