search

strongloop / strong-pm

deployer for node applications
http://strong-pm.io
Other
1k stars 71 forks source link

Update to WS api2 of strong-control-channel #256

Closed sam-github closed 9 years ago

sam-github commented 9 years ago

/to @rmg

This partly reverts strongloop/strong-runner#11, effectively, where you inject the channel into the runner constructors. That doesn't work well with the new API. We could push a request function in as an option, that would work better.

I reworked to use the patching of Runner approach again, which seems to work fine, though your comment on the runner PR seems to indicate that there was a problem. What was it?

I haven't run docker (or the unit tests) with this change, but I did deploy to sl-pm, and send the set-size command to the running instance, so it passes a smoke test.

I'd like some more comment before continuing.

connected to strongloop-internal/scrum-nodeops#775

Setogit commented 9 years ago

https://github.com/strongloop/strong-pm/blob/ws-api2/lib/drivers/direct/index.js#L168

@sam-github Don't we need to put this._channel.request call in else clause?

sam-github commented 9 years ago

@slnode test please

rmg commented 9 years ago

LGTM, :shipit: