search

strongloop / strong-pm

deployer for node applications
http://strong-pm.io
Other
1k stars 71 forks source link

pm: startup log of base dir and pid #266

Closed sam-github closed 9 years ago

sam-github commented 9 years ago

connected to strongloop-internal/scrum-nodeops#747

rmg commented 9 years ago

:+1: on intent, but it raises the question of whether this is something that should be handled by a logger.. I'm ok with punting on that conversation for another time, though.

LGTM

rmg commented 9 years ago

The failed test is a timeout because a test app is spinning with EADDRINUSE.. weird.

sam-github commented 9 years ago

@slnode test please

sam-github commented 9 years ago

I don't know how long we'll get by without a logger, particularly one that is run-time configurable. I want to send a message to mesh/pm saying slc ctl set-log-level INFO. DEBUG has been getting us by so far, its really simple, and does almost enough.

sam-github commented 9 years ago

@slnode test please

sam-github commented 9 years ago

Its hard to believe this could cause a test failure, but I'll keep poking it until it goes green.

sam-github commented 9 years ago

@rmg I poked master, we'll see if its green, this is a time suck. :-(

sam-github commented 9 years ago

@slnode test please

sam-github commented 9 years ago

@slnode test please

sam-github commented 9 years ago

@slnode test please