search

strongloop / strong-pm

deployer for node applications
http://strong-pm.io
Other
1k stars 71 forks source link

Use a named file minkelite.db with overwrite option. #274

Closed Setogit closed 9 years ago

Setogit commented 9 years ago

connect to strongloop-internal/scrum-nodeops#869

Setogit commented 9 years ago

@slnode test please

kraman commented 9 years ago

:+1:

Setogit commented 9 years ago

@slnode test please

sam-github commented 9 years ago

@slnode test please

Setogit commented 9 years ago

i'm hesitant about merging because my local test fails on both master and this branch(same failure) Really okay to merge?

./test/test-install-systemd.sh ........................ 7/8
  not ok # exit 1 should be 0: 'node ../bin/sl-pm-install.js --port 7777 --job-file /var/folders/fr/n8lr0rq555l1r3b6v69ckb5h0000gn/T/sl-svc-installXXXXXX.ovXupoD7/systemd-with-docker.service --user seto --base /var/folders/fr/n8lr0rq555l1r3b6v69ckb5h0000gn/T/sl-svc-installXXXXXX.ovXupoD7/deeply/nested/sl-pm --driver docker --systemd'

Bail out! # # exit 1 should be 0: 'node ../bin/sl-pm-install.js --port 7777 --job-file /var/folders/fr/n8lr0rq555l1r3b6v69ckb5h0000gn/T/sl-svc-installXXXXXX.ovXupoD7/systemd-with-docker.service --user seto --base /var/folders/fr/n8lr0rq555l1r3b6v69ckb5h0000gn/T/sl-svc-installXXXXXX.ovXupoD7/deeply/nested/sl-pm --driver docker --systemd'
Setogit commented 9 years ago

The test failure on my local OSX turned out to be caused by docker being not installed while executing test-install-systemd.sh and test-install.sh. In the CI environment, dockers is available.

Merging to the master.