Enable Travis CI for this project

strongloop / strong-remoting

Communicate between objects in servers, mobile apps, and other servers.

www.strongloop.com

Other

105 stars 93 forks source link

Enable Travis CI for this project #202

Closed bajtos closed 9 years ago

bajtos commented 9 years ago

Based on the discussion in #195, I would like to enable Travis CI for this project.

Benefits:

Anonymous access to build results - contributors see why their pull request failed the build
The build fails whenever npm build fails. This allows us to control the acceptance criteria, most notably the build will fail on linter errors.

Close #195

/to @ritch please review /cc @rmg @raymondfeng @STRML

bajtos commented 9 years ago

Note that both loopback and loopback-datasource-juggler have Travis CI enabled.

ritch commented 9 years ago

Anonymous access to build results

Isn't ci.strongloop.com open and linked from PRs?

ritch commented 9 years ago

Anyways I like having a second source to verify that tests are actually failing instead of the CI which fails all the time for reasons unrelated to the PR.

ritch commented 9 years ago

@bajtos can we add the badge along with this PR?

STRML commented 9 years ago

Personally I can't access the CI without a user and pass, which I don't have. On Apr 14, 2015 5:14 PM, "Ritchie Martori" notifications@github.com wrote:

Anyways I like having a second source to verify that tests are actually failing instead of the CI which fails all the time for reasons unrelated to the PR.

— Reply to this email directly or view it on GitHub https://github.com/strongloop/strong-remoting/pull/202#issuecomment-93063350 .

ritch commented 9 years ago

Personally I can't access the CI without a user and pass, which I don't have.

Hmmm I did not know this. Thanks for mentioning it.

rmg commented 9 years ago

@ritch our CI is private, it requires a GitHub account in the strongloop org.

bajtos commented 9 years ago

@ritch can we add the badge along with this PR?

I am not sure if it's a good idea to add the badge. We used to have a problem in one of our other modules - it was not passing builds due to a timing/race condition in the tests, we didn't have time to fix, and thus the README was showing a red badge for quite some time. I know the right solution is to fix the build instead of hiding the badge, but sometimes the reality dictates different approach.

Also note that neither loopback nor loopback-datasource-juggler have the badge in their README.

@ritch Thoughts?

ritch commented 9 years ago

@bajtos ok... I am fine merging this without the badge.

I'd like to see badges eventually though. Don't you?