search

strongloop / strong-remoting

Communicate between objects in servers, mobile apps, and other servers.
www.strongloop.com
Other
105 stars 93 forks source link

Remove deprecation warning for res.send() #235

Closed beeman closed 9 years ago

beeman commented 9 years ago

Small patch that removes the following warnings:

express deprecated res.send(status, body): Use res.status(status).send(body) instead node_modules/loopback/node_modules/strong-remoting/lib/http-context.js:587:17
express deprecated res.send(status): Use res.sendStatus(status) instead node_modules/loopback/node_modules/strong-remoting/lib/http-context.js:593:13
slnode commented 9 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

bajtos commented 9 years ago

@slnode ok to test

bajtos commented 9 years ago

@slnode test please

bajtos commented 9 years ago

Hi @beeman, thank you for the patch, the changes LGTM. Our Travis CI builds are failing for this PR though, I need to find out what's happening before landing this pull request.

beeman commented 9 years ago

Hey @bajtos, thanks for looking at it. Please let me know if there is anything I can do to fix those tests.

bajtos commented 9 years ago

The build is failing with the same errors on the master branch too, I'll land this patch as it is.

Thank you for the contribution!