Closed digitalsadhu closed 9 years ago
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."
:+1:
@slnode ok to test
Hi @digitalsadhu, thank you for the pull request. Could you please add some unit-tests to verify the implementation and prevent regressions in the future? See https://github.com/strongloop/strong-remoting/commit/f26a87104045c5cbde29c02fcde679bb08e31109 for an inspiration.
@bajtos tests added, still seeing failing checks there. Not sure how I would resolve those as tests are all passing for me. Can you point me in the right direction?
LGTM.
@ritch would you like to take a look at this change yourself too?
still seeing failing checks there. Not sure how I would resolve those as tests are all passing for me. Can you point me in the right direction?
Those test failures are in projects that are using strong-remoting as a dependency. I think it's the loopback-example-oracle repository that is failing unit-tests because the oracle driver does not support Node v4.x yet.
@rmg any ideas how to fix this false alert?
@digitalsadhu don't worry about those dependent builds, I am ok to land the PR with loopback-example-oracle failing. Could you please squash the commits into a single one?
@bajtos Squashed
@digitalsadhu a nitpick, could you please fix the commit message to use the correct option name options.handleErrors
(plural, not singular)?
I asked @ritch to review and land this, I am on vacation tomorrow.
@bajtos @ritch Oops, fixed commit message now.
@bajtos they aren't warnings, the loopback-example-recipes module has a hard dependency on loopback-connector-oracle :-( I've opened an issue for it: strongloop/loopback-example-recipes#8
@bajtos how are we looking?
@digitalsadhu thanks for the reminder. Since @ritch has not commented, I'll assume he does not have any major objections.
Landed, thank you for the valuable contribution!
:+1:
Yay! Thanks guys.
On Wed, 21 Oct 2015 at 15:33, Ritchie Martori notifications@github.com wrote:
[image: :+1:]
— Reply to this email directly or view it on GitHub https://github.com/strongloop/strong-remoting/pull/248#issuecomment-149897095 .
Released to npmjs.org as strong-remoting@2.22.0
Enjoy :)
@digitalsadhu I'd like to add this to the API documentation on https://apidocs.strongloop.com/strong-remoting/ but I'm not sure where it should go. Can you give me a pointer?
@crandmck I think here is a better place where to document this new feature: https://docs.strongloop.com/display/LB/config.json?src=search#config.json-Remotingproperties
The property name is rest.handleErrors
.
While you are at it, could you please document rest.handleUnknownPaths
too? It was added by f26a87104.
@bajtos Thank you, that does make more sense.
I added both those properties to https://docs.strongloop.com/display/LB/config.json#config.json-Remotingproperties. In particular, the descriptions could perhaps have a bit more... PTAL.
Nice! 1 thing though, typo: "handleErros" : true,
Doh! Thanks for catching--fixed...
@crandmck I have added a bit more info, PTAL.
Thanks again @bajtos
options.handleErrors = false will allow the RestAdapter error handler to be bypassed
See: https://github.com/strongloop/loopback/issues/445#issuecomment-147722977 for discussion
@bajtos does this look ok?