strongloop / strong-remoting

Communicate between objects in servers, mobile apps, and other servers.
www.strongloop.com
Other
105 stars 93 forks source link

Retain accepted content-type with no-content #270

Closed davidcheung closed 8 years ago

davidcheung commented 8 years ago

rest.test.js

Connected to strongloop/strong-remoting/issues/258

davidcheung commented 8 years ago

@bajtos I have refactored the implementation, can you take a look to provide some feedback to see if it make sense?

bajtos commented 8 years ago

@davidcheung cool, the new implementation looks great! I left few comments on what to improve, this patch is almost good to be landed.

Please ping @ritch to see if he has time to give this the final review and land it while I am offline. If he hasn't, then I can land it on Monday.

davidcheung commented 8 years ago

@bajtos I have updated the code as per suggestions, looks much nicer now.

@bajtos or @ritch, please review

bajtos commented 8 years ago

LGTM. Landed, thank you!