search

strongloop / strong-remoting

Communicate between objects in servers, mobile apps, and other servers.
www.strongloop.com
Other
105 stars 93 forks source link

socket-io example doesn't work #280

Closed webup closed 7 years ago

webup commented 8 years ago

Seems the code of "client.js" is out-of-date...

Error: Cannot find module '../../client/js/client'
    at Function.Module._resolveFilename (module.js:339:15)
    at Function.Module._load (module.js:290:25)
    at Module.require (module.js:367:17)
webup commented 8 years ago

After some dive into lib/socket-io-adapter.js and remote-objects.js, I found adaptor's connect method is not implemented for its potential invoking in RemoteObjects.prototype.connect, any special reason here?

richardpringle commented 8 years ago

Hey @webup, sorry about the delay in response time! You're right, that example is outdated. ..and some of the socket-io adapter code is outdated as well.

Feel free to try and make the fix yourself and submit a PR. Otherwise, you'll have to be patient and wait until one of us get to this issue.

Thanks for pointing it out and happy coding!

richardpringle commented 8 years ago

All the info you need about the contribution process is right here

bajtos commented 7 years ago

I am afraid the socket.io adapter won't be a priority for us in the foreseeable future. Having said that, if you would like to fix this issue yourself, then I am happy to help you along the way.