strongloop / strong-remoting

Communicate between objects in servers, mobile apps, and other servers.
www.strongloop.com
Other
105 stars 93 forks source link

Drop support for Node v0.10 and v0.12 #382

Closed bajtos closed 7 years ago

bajtos commented 7 years ago

Connect to strongloop/loopback#2807

@rmg @sam-github please review cc @strongloop/loopback-dev

bajtos commented 7 years ago

@rmg How can we instruct ci.strongloop.com (pr-builder) to not run tests in this branch on Node v0.10 and v0.12?

bajtos commented 7 years ago

How can we instruct ci.strongloop.com (pr-builder) to not run tests in this branch on Node v0.10 and v0.12?

@rmg Actually, we need to do the same for CIS jenkins too, looks like it's not honouring the engine field (yet?).

rmg commented 7 years ago

cis-jenkins has separate checks for this. Once the change is merged, it removes the unsupported versions from the config. Before merge it uses a dynamic check that simply marks the build as passing without actually building anything.

ci.strongloop.com, on the other hand, is completely manual. We'll have to modify the projects.yml file to make changes there.

bajtos commented 7 years ago

@rmg thank you. The catch is that we would like to keep running Node v0.12 on CI for 2.x branches where we still support Node v0.12 while it's in LTS mode.

cis-jenkins has separate checks for this. Once the change is merged, it removes the unsupported versions from the config. Before merge it uses a dynamic check that simply marks the build as passing without actually building anything.

Does this mean 2.x branch won't be run on Node v0.12 after we remove Node v0.12 from the engines field on master? That's not what we want :(

ci.strongloop.com, on the other hand, is completely manual. We'll have to modify the projects.yml file to make changes there.

Is it possible to choose Node versions on per-branch basis? If not, then I am proposing to use a dynamic check similar to what cis-jenkins is doing and sort-circuit the build when node -v is not compatible with package.json > engines.node field. I am happy to contribute this change if that helps.

bajtos commented 7 years ago

ci.strongloop.com, on the other hand, is completely manual. We'll have to modify the projects.yml file to make changes there.

Is it possible to choose Node versions on per-branch basis? If not, then I am proposing to use a dynamic check similar to what cis-jenkins is doing and short-circuit the build when node -v is not compatible with package.json > engines.node field. I am happy to contribute this change if that helps.

@rmg I went ahead and implemented short-circuiting, please review: https://github.com/strongloop-internal/build-framework/pull/11

bajtos commented 7 years ago

@slnode test please

bajtos commented 7 years ago

@slnode test please

bajtos commented 7 years ago

@slnode test please

bajtos commented 7 years ago

@slnode test please

bajtos commented 7 years ago

@slnode test please