Upgrade eslint-config, improve npm scripts

strongloop / strong-remoting

Communicate between objects in servers, mobile apps, and other servers.

www.strongloop.com

Other

105 stars 93 forks source link

Upgrade eslint-config, improve npm scripts #394

Closed bajtos closed 7 years ago

bajtos commented 7 years ago

Add "npm run lint" script
Use dot reporter in "npm test". We have more than 2000 tests now, listing names of all these tests is rather unpractical.
Upgrade eslint-config to 7.x, upgrade grunt-eslint to 19.x and add dirty-chai dev-dependency to get rid of property-based assertions.

@superkhau PTAL

bajtos commented 7 years ago

The best way for reviewing the diff is to ignore white-space changes - https://github.com/strongloop/strong-remoting/pull/394/files?w=1

bajtos commented 7 years ago

@slnode test please

bajtos commented 7 years ago

Why default mocha to -R dot

With the default "list" reporter, npm test prints over 2000 lines to stdout, which I find annoying. loopback uses the "dot" reporter too, see https://github.com/strongloop/loopback/blob/4e6f9b978a50af82e2b8b461caf4d418ee439f43/Gruntfile.js#L92.

(ie. should we do it across the board or some specific reason this repo is different?).

To be honest, I don't care. I think there is no harm in using the "dot" reporter in all our projects, but at the same time I don't think it's worth the effort.

superkhau commented 7 years ago

...prints over 2000 lines to stdout, which I find annoying.

Agreed lol, 2K lines sounds annoying.

...no harm in using the "dot" reporter...

I agree with it's not worth the effort. Based on your point above though, I will do it for some repos that are absurdly long (ie. like juggler too) on as needed basis too. :bowing_man: