strongloop / strong-remoting

Communicate between objects in servers, mobile apps, and other servers.
www.strongloop.com
Other
105 stars 93 forks source link

Disable remote methods by alias #395

Closed Overdrivr closed 7 years ago

Overdrivr commented 7 years ago

Description

Backport of #385

Related issues

Checklist

slnode commented 7 years ago

Can one of the admins verify this patch?

slnode commented 7 years ago

Can one of the admins verify this patch?

slnode commented 7 years ago

Can one of the admins verify this patch?

bajtos commented 7 years ago

The change in lib looks like a straightforward backport of the change from the master, which is good! I'll leave the detailed review to @gunjpan though.

@Overdrivr could you please rebase your patch on top of the latest 2.x branch to satisfy the "PR Linter" check, which is currently failing?

Overdrivr commented 7 years ago

@bajtos @gunjpan Rebase done and all checks passing, ready for review

bajtos commented 7 years ago

Landed, thank you for the contribution!

gunjpan commented 7 years ago

@bajtos : It was straight forward backport, but couldn't get to review due to priorities. Thank you for chiming in :smiley: