Remote method returned promise args do not respect http.target

strongloop / strong-remoting

Communicate between objects in servers, mobile apps, and other servers.

www.strongloop.com

Other

105 stars 93 forks source link

Closed mitsos1os closed 7 years ago

mitsos1os commented 7 years ago

When a remote method returns a Promise, the return arguments that should affect status or header properties are not handled properly

407
- [x] New tests added or existing tests modified to cover all changes
- [x] Code conforms with the style guide

slnode commented 7 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

slnode commented 7 years ago

Can one of the admins verify this patch?

slnode commented 7 years ago

Can one of the admins verify this patch?

slnode commented 7 years ago

Can one of the admins verify this patch?

bajtos commented 7 years ago

Awesome, thank you @mitsos1os for the pull request. I'll review the changes in the next few days (fingers crossed 🤞 )

bajtos commented 7 years ago

@slnode ok to test

bajtos commented 7 years ago

Landed, thank you for the contribution!