Update sse to 0.0.7 - Githubissues

strongloop / strong-remoting

Communicate between objects in servers, mobile apps, and other servers.

www.strongloop.com

Other

105 stars 93 forks source link

Update sse to 0.0.7 #437

Closed smartmouse closed 6 years ago

smartmouse commented 6 years ago

Description

Related issues

[x] New tests added or existing tests modified to cover all changes
[x] Code conforms with the style guide

smartmouse commented 6 years ago

Do you know why CI for nvm 4 fails? node 6,8 passed though.

rmg commented 6 years ago

CI is failing on node v4 because npm v2 can't install the dependencies properly - because the phantomjs-prebuilt uses dependencies during its install script but doesn't bundle them to ensure they are present. It's a bug in phantomjs-prebuilt that is unlikely to be fixed (I've tried before, nobody cares enough).

smartmouse commented 6 years ago

In ourJenkins build, can we use npm 3.10.10 with node 4.x? I think we should up our minimum npm version to npm 3.x. Is it save to merge ? in our staging CI build , it is using npm 3.