deleteType support in loopback 2.x

snarjuna commented 6 years ago

deleteType to remove type from existing types. This is equivalent to deleteType for typeRegistry which exist in loopback 2.x

slnode commented 6 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

snarjuna commented 6 years ago

@bajtos As per our discussion, I have created a PR to support delete types. Please review and merge

bajtos commented 6 years ago

thank you @snarjuna for the pull request! The changes look good, let's fix the CI checks now.

commits in this PR have formatting problems

Our commit message conventions are described here: https://loopback.io/doc/en/contrib/git-commit-messages.html Most importantly, we use imperative form instead of past tense.

While you are making those changes, please squash both commits into single one (git rebase -i master && git push -f).

One or more of this commit's parents has contributors who have not signed the Contributor License Agreement.

Unfortunately, this step is required from IBMers too.

snarjuna commented 6 years ago

@bajtos I have resolved your comments. Can you please merge now

bajtos commented 6 years ago

Landed. 🎉 Thank you for the contribution! ❤️

strongloop / strong-remoting