strongloop / strong-remoting

Communicate between objects in servers, mobile apps, and other servers.
www.strongloop.com
Other
105 stars 93 forks source link

Update eslint & config to latest #470

Closed bajtos closed 5 years ago

bajtos commented 5 years ago

It's probably best to review the changes commit-by-commit:

bajtos commented 5 years ago

Looks good. Any reason for changing options to opts ?

Good catch, I am glad you asked! In the original code, the following line is longer than 90 characters allowed by our eslint config:

const sharedMethod = new SharedMethod(myFunction, 'myName', mockSharedClass, options);

The rename makes it short enough to pass the check :)

const sharedMethod = new SharedMethod(myFunction, 'myName', mockSharedClass, opts);