search

strongloop / strong-service-install

Create/install system service for a given app
Other
7 stars 3 forks source link

Initial version #3

Closed rmg closed 10 years ago

rmg commented 10 years ago

PR for review.

sam-github commented 10 years ago

LGTM, other than two comments above.

sam-github commented 10 years ago

And thanks for splitting the initial code from the initial commit! I think you might want to reword the second commit, though, so it doesn't look like a rebase error... two commits with identical subject!

rmg commented 10 years ago

You commented while I was in the middle of squashing - those exports weren't even in the final version :-)