strongloop / strong-supervisor

Application supervisor that automatically adds cluster control and performance monitoring with StrongOps
Other
66 stars 20 forks source link

fix accidental heapdump generation on log re-open #152

Closed rmg closed 9 years ago

rmg commented 9 years ago

The heapdump module by default triggers on SIGUSR2, but we use that signal to re-open our log files. The result is we generate a heapdump every time the logs are rotated.

Connect to #150

sam-github commented 9 years ago

ah, you changed it already, my mistake, I somehow was seeing the wrong page.

anyhow, LGTM

rmg commented 9 years ago

Ya, sorry I wasn't clear. I was just added references to the discussion, not a real rebuttal :-)

rmg commented 9 years ago

@slnode test please