Closed bhajian closed 8 years ago
@sam-github : PTAL, I have disabled some test cases, however, there are certain commands that are not executed on my machine related to shelljs (windows throws an exception when it hits shelljs). On the other hand, I did not get the logic where runctl file is expected to execute an app.
There is a lot of code commented out that would never be hit by strong-liberty-pm. Did you delete everything, or just things you had to for liberty-pm?
I did not get the logic where runctl file is expected to execute an app
Not sure what this means.
If its working for liberty-pm, then try to minimize the changes, some strategies:
Any diffs in here are likely to conflict as we maintain this fork, so its best to minimize.
@sam-github PTAL, The changes are now minimized to all the watchers, sl-run, runctl, tracer and metrics. all of the test cases failing but 1,2 files.
You don't have the heartbeat generator and the tests are failing.
@sam-github PTAL
You should split this into two commits, one removes strong-agent, one adds a fake "metrics" message.
http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
Follow commit message standard form:
also, don't use strong-supervisor:
as a component: the first commit applies to the whole repo, so just "Remove ..." is OK as a commit subject.
LGTM, other than the period on the commit message. Fix and re-PR this branch.
@slnode test please
@slnode please test
This PR got closed by #173
connect to strongloop-internal/scrum-nodeops#1188