Remove strong-agent as a dependency- original

strongloop / strong-supervisor

Application supervisor that automatically adds cluster control and performance monitoring with StrongOps

Other

66 stars 20 forks source link

Remove strong-agent as a dependency- original #172

Closed bhajian closed 8 years ago

bhajian commented 8 years ago

connect to strongloop-internal/scrum-nodeops#1188

bhajian commented 8 years ago

@sam-github : PTAL, I have disabled some test cases, however, there are certain commands that are not executed on my machine related to shelljs (windows throws an exception when it hits shelljs). On the other hand, I did not get the logic where runctl file is expected to execute an app.

sam-github commented 8 years ago

There is a lot of code commented out that would never be hit by strong-liberty-pm. Did you delete everything, or just things you had to for liberty-pm?

I did not get the logic where runctl file is expected to execute an app

Not sure what this means.

sam-github commented 8 years ago

If its working for liberty-pm, then try to minimize the changes, some strategies:

don't comment out test code, choose the explicit files to be run by tap in the package.json test script
don't comment out code in branches that aren't hit (capabilities.js, call sl-run.js without --tracing, so tracing code isn't hit, and with --no-profile, so you don't have to comment out the branches where profiling is hit, etc.)

Any diffs in here are likely to conflict as we maintain this fork, so its best to minimize.

bhajian commented 8 years ago

@sam-github PTAL, The changes are now minimized to all the watchers, sl-run, runctl, tracer and metrics. all of the test cases failing but 1,2 files.

sam-github commented 8 years ago

You don't have the heartbeat generator and the tests are failing.

bhajian commented 8 years ago

@sam-github PTAL

sam-github commented 8 years ago

You should split this into two commits, one removes strong-agent, one adds a fake "metrics" message.

sam-github commented 8 years ago

http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

Follow commit message standard form:

use imperative "Remove strong-agent as a dependency" not "Removing ..."
use 50 char or less subjects
use capitalized sentences with a period in the commit message body

also, don't use strong-supervisor: as a component: the first commit applies to the whole repo, so just "Remove ..." is OK as a commit subject.

sam-github commented 8 years ago

LGTM, other than the period on the commit message. Fix and re-PR this branch.

bhajian commented 8 years ago

@slnode test please

bhajian commented 8 years ago

@slnode please test

bhajian commented 8 years ago

This PR got closed by #173