Closed bajtos closed 8 years ago
I think anything you don't need should be disabled, and lots of things are enabled by default: https://github.com/RuntimeTools/appmetrics#appmetricsenabletype-config
other than that, looks good
to turn off the MQTT connection, you can modify the appmetrics.properties file and set the com.ibm.diagnostics.healthcenter.mqtt=off
to turn off the MQTT connection, you can modify the appmetrics.properties file and set the com.ibm.diagnostics.healthcenter.mqtt=off
Thank you @tobespc. I implemented a post-install script to edit that setting in 7c6de0a.
@sam-github I think this patch is ready for another round of review, PTAL.
@slnode test please
@rmg I am confused about the reason why the tests are failing on some platform, could you please help me to investigate?
amazon-5 and ubuntu-5 cannot install appmetrics
. I am checking with the appmetrics' team whether 5.x is supported.
However, other platforms are failing because of malformed TAP output, see e.g. http://ci.strongloop.com/job/strong-supervisor/label=amazon-4/1792/console:
org.tap4j.parser.ParserException: Error parsing TAP Stream: Duplicated TAP Plan found.
at org.tap4j.parser.Tap13Parser.parse(Tap13Parser.java:221)
at org.tap4j.parser.Tap13Parser.parseFile(Tap13Parser.java:187)
@slnode test please
LGTM, other than the stack trace. Please change that, and land.
Add a new watcher called "appmetrics" that emits the following two events via the IPC channel:
Connect to strongloop-internal/scrum-nodeops#1057
@sam-github please review