Closed sam-github closed 8 years ago
🎉 +286 −437
🎉
I think these changes are breaking enough that we should probably put some sort of notice in the README.md. I'm thinking specifically of the removal of --detach
, which I recall people actually using for some reason.
Left a couple comments on the tests (which I'm sure are completely unsurprising by now). Those are just nits/suggestions, though.
The only thing I really want to see before merge/release is a warning added to the README about the "loss" (:tada:) of --detach
.
@slnode test please
@slnode test please
I'm prepared to ignore the downstream "dependants", which don't actually depend on 5.x of strong-supervisor
@slnode test please
Sorry for the slow response.. LGTM, :shipit: !
LGTM
Remove no longer used features from strong-supervisor to eliminate dead code.
connected to https://github.com/strongloop-internal/scrum-nodeops/issues/1535