search

strongloop / strong-supervisor

Application supervisor that automatically adds cluster control and performance monitoring with StrongOps
Other
66 stars 20 forks source link

Strip and clean #188

Closed sam-github closed 8 years ago

sam-github commented 8 years ago

Remove no longer used features from strong-supervisor to eliminate dead code.

connected to https://github.com/strongloop-internal/scrum-nodeops/issues/1535

rmg commented 8 years ago

🎉 +286 −437 🎉

rmg commented 8 years ago

I think these changes are breaking enough that we should probably put some sort of notice in the README.md. I'm thinking specifically of the removal of --detach, which I recall people actually using for some reason.

rmg commented 8 years ago

Left a couple comments on the tests (which I'm sure are completely unsurprising by now). Those are just nits/suggestions, though.

The only thing I really want to see before merge/release is a warning added to the README about the "loss" (:tada:) of --detach.

rmg commented 8 years ago

@slnode test please

sam-github commented 8 years ago

@slnode test please

sam-github commented 8 years ago

I'm prepared to ignore the downstream "dependants", which don't actually depend on 5.x of strong-supervisor

rmg commented 8 years ago

@slnode test please

rmg commented 8 years ago

Sorry for the slow response.. LGTM, :shipit: !

kjdelisle commented 8 years ago

LGTM