search

strongloop / strong-supervisor

Application supervisor that automatically adds cluster control and performance monitoring with StrongOps
Other
66 stars 20 forks source link

Fix eslint errors #195

Closed kjdelisle closed 8 years ago

kjdelisle commented 8 years ago

connected to https://github.com/strongloop-internal/scrum-nodeops/issues/1596

kjdelisle commented 8 years ago

PTAL @sam-github

sam-github commented 8 years ago

Commit body should be either a bullet list, or a properly formed paragraph (with sentence-ending periods).

sam-github commented 8 years ago

I think I would use commit subject of 'Add 'use strict' to all files', fix eslint errors is kindof vague. And the only thing that wasn't the insert of use strict was the package... and that only applies in strict mode, so it is a use strict thing.

kjdelisle commented 8 years ago

@sam-github Edit: I've split them up into two commits for clarity.

kjdelisle commented 8 years ago

@sam-github All good now?

sam-github commented 8 years ago

@kjdelisle did you mean to merge those two commits together?

kjdelisle commented 8 years ago

@slnode test please

kjdelisle commented 8 years ago

@sam-github PTAL

sam-github commented 8 years ago

LGTM