search

strongloop / strong-supervisor

Application supervisor that automatically adds cluster control and performance monitoring with StrongOps
Other
66 stars 20 forks source link

graceful-fs@2 and @3 support will be removed soon #200

Closed ChALkeR closed 7 years ago

ChALkeR commented 8 years ago

Hi. strong-supervisor is currently #81 in my list of modules that would likely to be broken when https://github.com/nodejs/node/pull/6413 lands (which is anticipated to happen before v7.0).

Note that graceful-fs@1 and graceful-fs@4 are ok and would not be broken by this, but a require() on graceful-fs@2 or graceful-fs@3 would cause an error soon.

That is, runtime warning fs: re-evaluating native module sources is not supported. would be turned into a throw.

If you or your deps use graceful-fs@2 or graceful-fs@3 in runtime — you are affected.

Tracking: https://github.com/nodejs/node/issues/5213.

sam-github commented 8 years ago

Thanks @ChALkeR, will be fixed by #199 - we inherit this from try-thread-sleep, the dep is being removed.