search

strongloop / strong-supervisor

Application supervisor that automatically adds cluster control and performance monitoring with StrongOps
Other
66 stars 20 forks source link

Backport non-breaking changes from 5.x #204

Closed rmg closed 8 years ago

rmg commented 8 years ago

I'd like to publish a maintenance release of the 3.x line. This is all of the non-breaking changes that have been merged to master + #201.

@sam-github in order to resolve #203, I'm considering back-porting 1a36fb4 (the one commit from #199 that was skipped), but I'm not sure if we should consider it a breaking change or not. Technically, it is removing a feature and therefore breaking.. but I don't know if it was ever actually used or documented, which would make it a non-semver-major change. Thoughts?

sam-github commented 8 years ago

LGTM

Also, the removing of agent:trace (1a36fb4) seems fine to me. strong-pm used the feature, but if its test aren't broken (and the green for this PR on ci indicates it isn't) then it should be OK.

rmg commented 8 years ago

@sam-github I hadn't included the agent-trace removal in the first batch, but I've just added it. We'll see shortly whether it breaks strong-pm or not.

rmg commented 8 years ago

It passes, but as far as I can tell the only test in strong-pm for agent:trace is not only skipped, but even if it was run it is tested with mocks anyway :-(

From a code walk through strong-pm, strong-mesh-models, and strong-arc, though, I agree with your original assessment that it is completely unused.

@sam-github can I get one more LGTM to ACK this before I merge? Just want to make sure I'm reading you correctly.

sam-github commented 8 years ago

LGTM