search

strongloop / strong-supervisor

Application supervisor that automatically adds cluster control and performance monitoring with StrongOps
Other
66 stars 20 forks source link

Expose appmetrics #210

Closed sam-github closed 7 years ago

sam-github commented 7 years ago

connected to https://github.com/strongloop-internal/scrum-nodeops/issues/1465

sam-github commented 7 years ago

@tobespc PTAL

tobespc commented 7 years ago

LGTM but the failure checks, are they a concern ?

sam-github commented 7 years ago

@tobespc the windows failures exist on master, they aren't specific to this PR. We are going to disable the supervisor tests on windows, they do too much child process manipulation, and process handling isn't so portable. It can be made to be, but I don't have the time, and API Connect doesn't support this on windows (and nobody deploys to windows).