Open kjdelisle opened 7 years ago
@tobespc ----^ I haven't reproed, I'll try after looking at some other fires
It looks like this may have been a bad packaging of apiconnect
I reopened, because I think #216 is just a work-around, and that something unexpected is happening we need to figure out.
I don't see a 'response' in the express data emitted, am I missing something? https://github.com/RuntimeTools/appmetrics/blob/master/probes/express-probe.js#L82-L89 Perhaps this got rewritten at some point?
Yes, it looks like the express probe was refactored at some point. https://github.com/RuntimeTools/appmetrics/pull/260
As long as strong-supervisor is getting all the express data it needs from appmetrics I would say we can just delete that check
i.e. remove the whole of if (probeName === 'express'...
and just have var duration = res.duration;
supervisor is getting what it needs, but that isn't quite enough. If this is related to RuntimeTools/appmetrics#260, it probably means that the structure of the data is different when the user's app includes https://www.npmjs.com/package/strong-express-metrics, and perhaps that the probe name is wrong? strong-express-metrics is a bit odd, its something that the user manually adds as middleware, and which then sends extra information up the stack: appmetrics -> supervisor -> strong-pm -> strong-arc. Whether its there or not, supervisor should still work.
Module versions: strong-supervisor@5.0.3 appmetrics@1.1.2 apiconnect-collective-member@1.4.10
Using the express-example-app@1.0.4 as my test application, after sending a GET request to the base route of the application, I receive this error: