search

strongloop / strong-tools

Tools for packaging, releasing, and preparing npm modules
Other
8 stars 7 forks source link

Use script version of sl-blip #42

Closed rmg closed 8 years ago

rmg commented 8 years ago

Algorithm:

  1. If sl-blip is detected in optionalDependencies, scripts.preinstall, scripts.install, or scripts.postinstall:
  2. overwrite scripts/sl-blip.js with latest version
  3. remove from optionalDependencies
  4. if not in scripts.preinstall, scripts.install, or scripts.postinstall:
    1. add to first unused install phase script

@gunjpan I was unsure how to describe in comments how I wanted #39 to look. I also merged #40 which would require you to rebase and resolve a bunch of conflicts. Rather than make you resolve the conflicts and us go back and forth in comments, I figured it would probably be faster if I just showed you how I would write it.

Connect to strongloop-internal/scrum-loopback#643 Connect to strongloop-internal/scrum-nodeops#1079 Replaces #39 and strongloop/strongloop#239

gunjpan commented 8 years ago

@rmg: Great insight and liked how concise it is! thank you for chiming in.

sam-github commented 8 years ago

I wonder whether a top-level hidden .sl-script.js would be better than creating a folder? The folder will either be empty, in which case why create it to hold just one script, or not-empty, in which case we are mixing our script with any other ones.

Remind me again why we didn't make a strong-blip dev dependency, and call the script from there? I think there was a reason we direct copy instead of doing that, I just don't remember.

rmg commented 8 years ago

@sam-github I think I've addressed your comments. Can I get an LGTM?

We can discuss the different approaches on Slack or a hangout, if you like.

sam-github commented 8 years ago

I would add one line of comment about pasteb.in, I didn't get the point from the code.

Otherwise, LGTM