search

strongloop / supercluster

A module to make it easy to distribute work across multiple network-connected hosts.
Other
30 stars 2 forks source link

sc-discovery uses git+ssh #5

Open mschmulen opened 10 years ago

mschmulen commented 10 years ago

package.json reference for sc-discovery uses git+ssh , this is probably not desirable since it can cause an authentication dependancy. 

"remove": "~0.1.5",
"request": "~2.27.0",
"sc-discovery": "git+ssh://git@github.com:strongloop/sc-discovery.git"

}, "devDependencies": {

... I check out some of the other repo's and that seems consistent , so maybe its no big deal.

stdarg commented 10 years ago

How so - it's a public repo. Btw, It's only temporary and will change soon, but I'm not sure I understand how auth comes up as an issue for a public repo, but I'd like to understand.

-Edmond

On Oct 31, 2013, at 10:16 AM, Matt Schmulen notifications@github.com wrote:

package.json reference for sc-discovery uses git+ssh , this is probably not desirable since it can cause an authentication dependancy.

"remove": "~0.1.5", "request": "~2.27.0", "sc-discovery": "git+ssh://git@github.com:strongloop/sc-discovery.git" }, "devDependencies": {

— Reply to this email directly or view it on GitHub.

mschmulen commented 10 years ago

... I check out some of the other repo's and that seems consistent , so maybe its no big deal.

I still have scar's from private github repos that worked on the developer machine but not on cloud platforms. since its a public repo no big deal.

thanks for the follow up !

sam-github commented 10 years ago

On Thu, Oct 31, 2013 at 10:19 AM, Edmond Meinfelder < notifications@github.com> wrote:

How so - it's a public repo. Btw, It's only temporary and will change soon, but I'm not sure I understand how auth comes up as an issue for a public repo, but I'd like to understand.

Because the URL forces the use of ssh to connect to github, and that doesn't work unless you have a github account, and ~/.ssh with your ssh keys in it. Which is pretty much every github user, but not everybody using git clone.

Since its a public repo, just use npm's github-specific dependency syntax, it will work for everyone:

'sc-discover': 'strongloop/sc-discover',