strongswan / davici

Decoupled Asynchronous VICI
GNU Lesser General Public License v2.1
20 stars 18 forks source link

Update davici to support Windows #2

Open KevinLussier opened 6 years ago

KevinLussier commented 6 years ago

These changes add in Windows support to davici. The main change involves using a TCP socket instead of a UNIX socket. Platform dependent types and macros were added:

Additionally:

martinwilli commented 6 years ago

Generally, I'd prefer to see some platform abstraction header, where we can put away all the differences between Windows and Unix systems.

martinwilli commented 6 years ago

Also, it would be nice to have some integration testing for the Windows build, as otherwise we likely break it with future changes. For strongSwan we use MinGW on Travis Linux hosts, that would certainly be an option. AppVeyor would be a good alternative, which Tobias added to strongSwan, too.

martinwilli commented 6 years ago

I'm not so happy with all those added casts, as they make the code rather unreadable. They mostly just silence some warnings; but maybe we can disable just those compiler warnings?