search

strongswan / strongMan

Management UI for strongSwan
https://www.strongswan.org/
Other
114 stars 39 forks source link

Added export feature #150

Closed theko2fi closed 8 months ago

theko2fi commented 9 months ago

This pull request is aimed at enabling users to export a certificate in either PEM or DER format. Previously, there was no mechanism to retrieve an uploaded certificate, and I have encountered a situation where the original certificate file was lost.

Please refer to the attached demo video for more details:

https://github.com/strongswan/strongMan/assets/72862222/48f01d71-46a4-470e-96f8-a9fc3ca01602

tobiasbrunner commented 9 months ago

Thanks for the PR. We require a CLA, see the instructions in the comment, @cla-bot check

cla-bot[bot] commented 9 months ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @theko2fi on file. In order for us to review and merge your code, please contact the project maintainers via info@strongswan.org to get yourself added.

cla-bot[bot] commented 9 months ago

The cla-bot has been summoned, and re-checked this pull request!

theko2fi commented 9 months ago

Thanks for your feedback, I already emailed the maintainers to express my willingness to sign the Contributor License Agreement.

tobiasbrunner commented 9 months ago

@cla-bot check

Thanks again. I feel like this could be simplified quite a bit (and the third-party script/CSS could also be avoided) by just providing a single format and button. PEM should be enough I think.

cla-bot[bot] commented 9 months ago

The cla-bot has been summoned, and re-checked this pull request!

theko2fi commented 9 months ago

@tobiasbrunner I've implemented the changes as suggested. The process has been simplified. Feel free to check it out, and let me know if you have any further thoughts.

tobiasbrunner commented 8 months ago

Thanks for the update. I've squashed your changed and pushed them with some changes to master. I've reformatted some stuff (code and HTML) and added support to export VICI certificates and handle names that contain e.g. spaces better.