search

strongswan / swidGenerator

Application which generates SWID-Tags from Linux package managers like dpkg, rpm or pacman.
MIT License
16 stars 11 forks source link

Issue104 return codes #18

Closed cfaessler closed 10 years ago

cfaessler commented 10 years ago

fixes https://github.com/tnc-ba/strongTNC/issues/104

dbrgn commented 10 years ago

Rebased using the following command:

git rebase --onto master 4bf4e1f issue104-return-codes

I'm not 100% sure if that was the correct way, but it worked with a single conflict.

cfaessler commented 10 years ago

thanks! you saved me from tears!

dbrgn commented 10 years ago

Good to merge!

cfaessler commented 10 years ago

Do you think we should also provide error handling if the (explicitly) specified environment with --environment can not be found? (if rpm or dpkg-query executable can not be found) https://docs.python.org/2/library/subprocess.html

dbrgn commented 10 years ago

Yes. Continue as discussed.

dbrgn commented 10 years ago

:sparkles: :sparkles: Review done. :sparkles: :sparkles:

In general, remember that docstrings should be written as "action steps", not as "description from outside", so:

Process and return two swid generators

instead of

Proccesses and returns two swid generators
cfaessler commented 10 years ago

:shit: :shit: :shit:

cfaessler commented 10 years ago

@dbrgn ready for review

dbrgn commented 10 years ago

Review done. After fixing the remaining issues, merge directly :)