search

strongswan / swidGenerator

Application which generates SWID-Tags from Linux package managers like dpkg, rpm or pacman.
MIT License
16 stars 11 forks source link

Targeted requests by package name or software-id #23

Closed cfaessler closed 10 years ago

cfaessler commented 10 years ago

Fixes https://github.com/tnc-ba/strongTNC/issues/186

cfaessler commented 10 years ago

@dbrgn ready to review

dbrgn commented 10 years ago

Looks good. Seems to work fine on Debian.

cfaessler commented 10 years ago

fixed issues

dbrgn commented 10 years ago

--help output in README is updated, but the strings in the argparse setup are still missing the spaces (e.g. here https://github.com/tnc-ba/swidGenerator/blob/9b58b2e7c91ea817b65fd00cae6fc6ca9dc10006/swid_generator/argparser.py#L53-L54), because the strings are directly concatenated.

dbrgn commented 10 years ago

And there's a PEP8 violation :stuck_out_tongue_closed_eyes: