search

strongswan / swidGenerator

Application which generates SWID-Tags from Linux package managers like dpkg, rpm or pacman.
MIT License
16 stars 11 forks source link

NIST.IR.8060 GEN-22 to 24 require three n8060 attributes. #41

Closed adelton closed 6 years ago

adelton commented 6 years ago

Swidval 0.5.0 furthermore requires all but envVarSuffix to be nonempty. Using reasonable Linux defaults.

adelton commented 6 years ago

When testing with swidval, errors

ERROR GEN-22-1: The <Payload> element does not provide a @n8060:pathSeparator attribute.
ERROR GEN-23-1: The <Payload> element does not provide a @n8060:envVarPrefix attribute.
ERROR GEN-24-1: The <Payload> element does not provide a @n8060:envVarSuffix attribute.

will be shown unless this pull request is applied on top of https://github.com/strongswan/swidGenerator/pull/39, otherwise the prefix n8060: refers to different XML namespace.

I did not want to create this pull request dependent on the other one though, for easier modifications and rebases.

tobiasbrunner commented 6 years ago

I've pushed your commits (with some minor changes to the commit messages) and another one that makes the addition of the schema URIs optional (Andreas asked for this) to the swid-updates branch. Let me know if that's OK for you.

adelton commented 6 years ago

Yes, thank you. Do you use that branch as a staging area before bringing the changes to master? I plan to do a bunch of additional pull requests, so I wonder if I should do it against master or swid-updates.

Also, Travis CI seems to fail because of xmlsec -- is that becase the XML format has changed and the tests need to be amended as well?

tobiasbrunner commented 6 years ago

Do you use that branch as a staging area before bringing the changes to master?

If Andreas has no objections I can merge that branch to master today. In any case, use that as base for your other pull requests.

Also, Travis CI seems to fail because of xmlsec -- is that becase the XML format has changed and the tests need to be amended as well?

No, that's because the certificate the students used for the integration tests has expired.

strongX509 commented 6 years ago

Hi,

I added a missing space separator in the schemaLocation enumeration and updated the README. Everything now looks fine to me so you can merge the branch.

Regards

Andreas

On 05.07.2018 10:22, Tobias Brunner wrote:

Do you use that branch as a staging area before bringing the changes
to master?

If Andreas has no objections I can merge that branch to master today. In any case, use that as base for your other pull requests.

Also, Travis CI seems to fail because of xmlsec -- is that becase
the XML format has changed and the tests need to be amended as well?

No, that's because the certificate the students used for the integration tests has expired.

====================================================================== Andreas Steffen andreas.steffen@strongswan.org strongSwan - the Open Source VPN Solution! www.strongswan.org Institute for Networked Solutions HSR University of Applied Sciences Rapperswil CH-8640 Rapperswil (Switzerland) ===========================================================[INS-HSR]==

adelton commented 6 years ago

Thank you for catching that missing space bug. And thank you for the merge.

adelton commented 6 years ago

No, that's because the certificate the students used for the integration tests has expired.

Will you be able to get the certificate issue fixed so that CI tests run well for pull requests?