search

strongtz / i915-sriov-dkms

dkms module of Linux i915 driver with SR-IOV support
1.1k stars 135 forks source link

fix bug on kernels < 6.6.14 #164

Closed WR-Maox closed 6 months ago

WR-Maox commented 6 months ago

dkms.conf configuered exclusive_kernels as: BUILD_EXCLUSIVE_KERNEL="^(6.[1-5].)" However code here is only for kernel >=6.6.14. This change fix bugs when building on kernels of lower versions such as 6.5.11

michael-pptf commented 6 months ago

Gosh we really got hung up on this crap drm_dp_calc_pbn_mode.

I think this needs to be kernel specific. Before meddling with this the repo worked with 6.2, then we PR'd to make it work with 6.5 but not anything lower.

So what's the state on this now? Does it build on 6.2 but not greater than 6.5? Linux guests are not getting anything newer than 6.5 per one commentor #163

michael-pptf commented 6 months ago

See #165.

It looks like this merge breaks compatibility with 6.5.13-5-pve

WR-Maox commented 6 months ago

Gosh we really got hung up on this crap drm_dp_calc_pbn_mode.

I think this needs to be kernel specific. Before meddling with this the repo worked with 6.2, then we PR'd to make it work with 6.5 but not anything lower.

So what's the state on this now? Does it build on 6.2 but not greater than 6.5? Linux guests are not getting anything newer than 6.5 per one commentor #163

Maybe the signature of drm_dp_calc_pbn_mode changes at version 6.5.13?
I saw previous code used different args for kernels before and after 6.6.14 and didn't think too much. Shall we test with condition 6.5.13 other than 6.6.14 for different signature of drm_dp_calc_pbn_mode? Unfortunately, I have only kernel 6.5.11 and 6.8.4 (which is unsupported now) at hand.