strongtz / i915-sriov-dkms

dkms module of Linux i915 driver with SR-IOV support
1.1k stars 135 forks source link

Correction for PR #178 #179

Closed pasbec closed 4 months ago

pasbec commented 4 months ago

Hi @strongtz,

Shame on me - i had a small typo DEFINE_EXTRAVERSION vs EXTRAVERSION_DEFINE in the Makefile of my last PR due to some last minute changes. This fixes PR #178 and adds some option to overwrite the default GuC firmware if necessary.

Sorry for the inconveniences. Should have made a last test before opening the last PR.

IanRanson commented 4 months ago

Was getting build errors with main branch, but can confirm this PR works well. Thanks so much for your great work!

ich777 commented 4 months ago

I just wanted to point out that it won't compile because of a few errors. With this PR everything compiles just fine and I've already built a package for the Unraid community to test.

pasbec commented 4 months ago

Thank you @IanRanson and @ich777 . I tried to sneak that fix into the last PR but it was simply merged to quickly. 🫣

ich777 commented 4 months ago

I'm sure @strongtz will merge it ASAP. :)

johntdavis84 commented 4 months ago

Will the merge include updates to the README/front page to refresh to list of compatible kernels on the host and inside the VM?


John T Davis @.***

On Jul 17, 2024, at 12:52 PM, Christoph Hummer @.***> wrote:

I'm sure @strongtz https://github.com/strongtz will merge it ASAP. :)

— Reply to this email directly, view it on GitHub https://github.com/strongtz/i915-sriov-dkms/pull/179#issuecomment-2233881132, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGI5CYXAM7NDS7WLIKALQFTZM2VM5AVCNFSM6AAAAABLBA3X7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZTHA4DCMJTGI. You are receiving this because you are subscribed to this thread.

pasbec commented 4 months ago

Will the merge include updates to the README/front page to refresh to list of compatible kernels on the host and inside the VM?

I've only done some brief update of the README.md and listed (added) the Proxmox kernels that I tested in PR #178 but there is no change in #179. Without testing other distros and different kernels (e.g. Proxmox has no 6.6 or 6.7) it is quite hard to tell which kernels are actually working.

ich777 commented 4 months ago

@pasbec working fine on Unraid: grafik