stronnag / mwptools

ground station, mission planner and tools for inav and multiwii-nav
http://stronnag.github.io/mwptools/
GNU General Public License v3.0
190 stars 35 forks source link

Multi Mission planning is broken #129

Closed b14ckyy closed 1 year ago

b14ckyy commented 1 year ago

If I plan a waypoint mission and then add a second one, the first mission stays on screen. Any further added waypoint is then just continuing the existing ones.

When I switch back to Mission 1, only the first mission is shown. Switching to 2 then shows all waypoints of both planned missions. After loading the missions to the FC they are also stored exactly that way. Mission 1 has 5 waypoints for example but Mission 2 then has 10 waypoints.

I can delete the waypoints 1-5 in mission 2 initially but when I try to switch back to Mission 1, the application crashes.

Seen on Versions: 5.295.580 4d6e772 and current master 5.311.575 c3008c0 OS: WSL2 Windows 11 FC Firmware independent

image image

INAV Configurator shows them as expected. Either ALL or Single mission: image image

stronnag commented 1 year ago

Confirmed . Thanks

b14ckyy commented 1 year ago

btw just one minor thing. When "Edit Waypoints" is active and I pan through the map, every time I release the left mouse button it creates a waypoint. its just a minor inconvenience but while you're at it, maybe this can be fixed as well?

stronnag commented 1 year ago

Should be fixed in master (and development) branches. I'll maybe build a .deb later.

b14ckyy commented 1 year ago

Great! Multi Mission switching works now properly and the WP creation during mouse panning is also fixed. One issue remains though: The crash when deleting multiple waypoints at the beginning of the mission. Does not seem to be related to multi mission.

Creating 10 waypoints in a row. Then select WP 1-5 in the WP list. Right click and delete selection. Application crashes. It just says "Segmentation Fault" in the shell. Nothing in the mwp_stderr_2022-12-14.txt

2022-12-14T15:49:45+0100 mwp 
2022-12-14T15:49:45+0100 buildinfo: 2022-12-14T14:39:27Z Linux-5.15.79.1-microsoft-standard-WSL2-x86_64-with-glibc2.29 Marc-Desktop
2022-12-14T15:49:45+0100 toolinfo: gcc 9.4.0 / ld.bfd / valac 0.48.6
2022-12-14T15:49:45+0100 version: mwp 006253a / 2022-12-14T14:18:17+00:00 5.311.575
2022-12-14T15:49:45+0100 "Ubuntu 20.04.5 LTS" on Marc-Desktop running Linux 5.15.79.1-microsoft-standard-WSL2 x86_64
2022-12-14T15:49:45+0100 WM: Wayland / Unknown DE
2022-12-14T15:49:45+0100 GL: Microsoft Corporation / D3D12 (NVIDIA GeForce GTX 1080 Ti)
2022-12-14T15:49:45+0100 hypervisor: wsl
2022-12-14T15:49:45+0100 GLib2 2.64
2022-12-14T15:49:45+0100 MQTT enabled via the "mosquitto" library
2022-12-14T15:49:45+0100 Failed to find "mavlogdump.py" on PATH
2022-12-14T15:49:45+0100 "fl2ltm 0.13, commit: 954494b" may be too old, upgrade recommended
2022-12-14T15:49:45+0100 Using speech api 1 [espeak]
2022-12-14T15:49:45+0100 Get map preference
2022-12-14T15:49:45+0100 Starting Bing proxy 
2022-12-14T15:49:45+0100 BB load async map zoom : true
2022-12-14T15:49:45+0100 Loaded /home/marc/.local/share/mwp/vcols.css
2022-12-14T15:49:45+0100 Fixed font true
2022-12-14T15:49:45+0100 Delta speed 0.000000
2022-12-14T15:49:45+0100 Show main window
2022-12-14T15:49:46+0100 UPower: Could not connect: No such file or directory
stronnag commented 1 year ago

I can't reproduce this crash on current master (but I did see it on an older build).

b14ckyy commented 1 year ago

I made a cleanup and fresh compile but still see it. Any way to do more intense logging? I think you told me in the past how to start it with debug logging or was that fl2xui? If that helps.

stronnag commented 1 year ago

There is no more useful logging for this case. I'll try on a Win11 VM when I can evict Mrs Stonnag from the desktop computer.

b14ckyy commented 1 year ago

No Rush. Right now I can work around that. Just needed multi mission with Useraction support for a test and INAV Mission Control does not support Useractions yet. So thanks a lot for your quick response.

stronnag commented 1 year ago

Same crash here on win11/WSL-G. Next up native Debian / Ubuntu / FreeBSD.

OS Works
Arch Y
FreeBSD Y
Debian Stable
Debian Testing
Ubuntu 20.04 Y
Ubuntu 22.04 ?
Win10/Cygwin
Win11/WSL N
b14ckyy commented 1 year ago

I place a bet on Ubuntu as well.

stronnag commented 1 year ago

I place a bet on Ubuntu as well.

Hope so, then there is a possibility to see why

stronnag commented 1 year ago

Reworked the way bulk delete works. Please try the latest master (or development). I could get it to crash on Ub 22.04 after multiple bulk-deletes. So it's now simpler ...

b14ckyy commented 1 year ago

Perfect! All working now. crated 50 waypoints and deleted the first 20 with no issue. Thanks a lot mate!