Handle time and timezone changes correctly

strooooke / quickfit

QuickFit is an Android app which lets you add preconfigured workouts to Google Fit with a single click.

Apache License 2.0

14 stars 4 forks source link

Handle time and timezone changes correctly #62

Closed strooooke closed 3 years ago

strooooke commented 5 years ago

The hopeful comment explains that I once thought that

time change events should happen only when
- user is currently traveling (probably does not care deeply about doing sports)
- DST change, deep at night
- user wilfully plays around with their system time settings (we're not caring for that)

I've learned by now that those happen more often; e.g. due to network-provided clock correction - and on some devices (old Huawei, sigh), quite often.

strooooke commented 5 years ago

Still ok with ignoring timezone changes (ignoring in the sense of allowing skipped or repeated alerts).

Should handle time changes correctly though: when skipping forward, catch up (at least the last one); when skipping backwards, don't repeat an already shown alert.