search

strophe / libstrophe

A simple, lightweight C library for writing XMPP clients
http://strophe.im/libstrophe
Other
401 stars 163 forks source link

Add xmpp_stanza_get_child_by_name_and_ns() #143

Closed jubalh closed 4 years ago

jubalh commented 4 years ago

I think it's fairly common in the XMPP world to actually want a stanza by it's NS but also want a certain name.

For example this was needed in Profanity: https://github.com/profanity-im/profanity/commit/68af0aad65d243e654866eac5a7cd728ee293aa0

jubalh commented 4 years ago

@pasis I updated the commit. Is it okay like this?

pasis commented 4 years ago

@jubalh Looks good, just fix the comments.

jubalh commented 4 years ago

@pasis okay. Adapted the PR. Is it okay like this?

pasis commented 4 years ago

Merged: cbe6701c14da93c5bf54a45087a9aae807b55199 . Thanks.