strophe / libstrophe

A simple, lightweight C library for writing XMPP clients
http://strophe.im/libstrophe
Other
401 stars 163 forks source link

./configure syntax error on Alpine #145

Closed gjabell closed 4 years ago

gjabell commented 4 years ago

Hey all,

I'm trying to package libstrophe / libmesode for Alpine Linux, and I'm running into the error when running the generated configure script:

checking for expat... ./configure: line 12910: syntax error: unexpected word (expected ")")

Code around the mentioned line is:

if test "x$ac_cv_header_expat_h" = xyes; then :

                                    expat_LIBS="-lexpat"
                                    PC_LIBS+=($expat_LIBS)

else
  as_fn_error $? "expat not found; expat required." "$LINENO" 5

fi

with the PC_LIBS+=($expat_LIBS) being line 12910.

Has anyone else run into a similar issue? I'm not sure whether this is a problem with Alpine or something else.

Thanks!

gjabell commented 4 years ago

Should also note that this doesn't seem to actually be related to expat, despite failing on that line; I have tried with both expat and expat-dev (expat development libs) installed, as well as with libxml2 and --with-libxml2 compiler flag, with the same result.

pasis commented 4 years ago

@gjabell , do you have this issue only with libmesode or with libstrophe too? libstrophe doesn't use arrays (the problem line you mentioned) for a long time. There are open issues regarding this in libmesode: profanity-im/libmesode#7, profanity-im/libmesode#11.

gjabell commented 4 years ago

I had the same issue with both libstrophe and libmesode (tried libstrophe after libmesode failed). I didn't find those issues yesterday for some reason, let me see if the patch in #7 works for alpine too and report back.

26.11.2019 08:41:32 Dmitry Podgorny notifications@github.com:

@gjabell [https://github.com/gjabell] , do you have this issue only with libmesode or with libstrophe too? libstrophe doesn't use arrays (the problem line you mentioned) for a long time. There are open issues regarding this in libmesode: profanity-im/libmesode#7 [https://github.com/profanity-im/libmesode/issues/7] , profanity-im/libmesode#11 [https://github.com/profanity-im/libmesode/pull/11] .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub [https://github.com/strophe/libstrophe/issues/145?email_source=notifications&email_token=AD4VEOEQ4RFYVKQIVJIVAFLQVTHKXA5CNFSM4JRLI7C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFFBGQI#issuecomment-558502721] , or unsubscribe [https://github.com/notifications/unsubscribe-auth/AD4VEOHZLBXJ2DFZNWCFKOTQVTHKXANCNFSM4JRLI7CQ] . [https://github.com/notifications/beacon/AD4VEOHXGHJZIQTIDI6SAE3QVTHKXA5CNFSM4JRLI7C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFFBGQI.gif]

gjabell commented 4 years ago

Looks like alpine has the same issue as BSD, using the patch from profanity-im/libmesode#11 fixed it and allowed the configure script to complete.

pasis commented 4 years ago

What version of libstrophe did you checked? Versions since 0.9.0 are not affected by this issue.

gjabell commented 4 years ago

I had issues with 0.9.3 and 0.9.2 for both libstrophe and libmesode. Might have also been an issue with the packaging script though.

26.11.2019 14:22:23 Dmitry Podgorny notifications@github.com:

What version of libstrophe did you checked? Versions since 0.9.0 are not affected by this issue.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub [https://github.com/strophe/libstrophe/issues/145?email_source=notifications&email_token=AD4VEOHXDSFB2ZBQEAWWR6DQVUPI3A5CNFSM4JRLI7C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFF7GAQ#issuecomment-558625538] , or unsubscribe [https://github.com/notifications/unsubscribe-auth/AD4VEOAPBQYGSV3SAWTMOETQVUPI3ANCNFSM4JRLI7CQ] . [https://github.com/notifications/beacon/AD4VEOEAPRBBF64N63AKDWTQVUPI3A5CNFSM4JRLI7C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFF7GAQ.gif]