search

strophe / libstrophe

A simple, lightweight C library for writing XMPP clients
http://strophe.im/libstrophe
Other
401 stars 163 forks source link

Add missing headers to resolver.c #150

Closed jubalh closed 4 years ago

pasis commented 4 years ago

@jubalh , please, move includes under #ifdef HAVE_CARES, because select() is used only for c-ares implementation. In select(2) manual I see:

       /* According to POSIX.1-2001, POSIX.1-2008 */
       #include <sys/select.h>

       /* According to earlier standards */
       #include <sys/time.h>
       #include <sys/types.h>
       #include <unistd.h>

So <time.h> is not needed as far as I understand. Please, use those 3 includes for earlier standards for non-windows platforms.

jubalh commented 4 years ago

@pasis I probably won't have time the next week. Could you do the changes to my PR?

pasis commented 4 years ago

@jubalh ok will do.

pasis commented 4 years ago

I've pushed modified patch to the master.