structurizr / dsl

Structurizr DSL
https://docs.structurizr.com/dsl
Apache License 2.0
1.41k stars 265 forks source link

Permit "instances" as child of deploymentNode #133

Closed erwanosouf closed 2 years ago

erwanosouf commented 2 years ago

The dsl for deploymentNode is as follows

deploymentNode <name> [description] [technology] [tags] [instances] {
    ...
}

With "description", "technology" and tags also permitted as children of deploymentNode element, which I personally prefer for readability.

However, the syntax forces to write all elements inline instead of as children in order to be able to specify an instance count.

What I would like to do :

deploymentNode <name> {
     description ""
     technology ""
     tags ""
     instances 42
}

This is not valid with regards to the DSL

Or

deploymentNode <name> 42 {
     description ""
     technology ""
     tags ""
}

This is valid with regards to the DSL but does not produces the expected output (showing the instance count on the deploymentNode).

See attached :

simonbrowndotje commented 2 years ago

I've added support for the following:

deploymentNode <name> {
     instances 42
}
erwan-osouf commented 2 years ago

Hey @simonbrowndotje !

Do you have any idea when this will be released ?

Thanks in advance !

simonbrowndotje commented 2 years ago

Probably some time in July.

erwanosouf commented 2 years ago

Thanks a lot for the fast reply!

Le jeu. 19 mai 2022 à 15:14, Simon Brown @.***> a écrit :

I've added support for the following:

deploymentNode { instances 42 }

— Reply to this email directly, view it on GitHub https://github.com/structurizr/dsl/issues/133#issuecomment-1131673624, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGQ3RLAV4DX4FWWOQSVDX3VKY5CHANCNFSM5WLPONEQ . You are receiving this because you authored the thread.Message ID: @.***>