structurizr / dsl

Structurizr DSL
https://docs.structurizr.com/dsl
Apache License 2.0
1.41k stars 265 forks source link

Hide a relationship in a view doesn't work for implied relationship #303

Closed max-arshinov closed 1 year ago

max-arshinov commented 1 year ago

Description

It seems that the advice from https://github.com/structurizr/dsl/issues/7 doesn't work with implied relationships.

Steps to reproduce

  1. Follow the advice from https://github.com/structurizr/dsl/issues/7
  2. Exclude both relationships (see the code sample below)

Expected Behavior Relationships are not shown

Actual Behavior Relationships are shown

Screenshot

image

Code sample

workspace {
    model {
        customer = person "User"

        system1 = softwareSystem "System 1" {
            container1 = container "Container 1"
            container2 = container "Container 2"
        }

        system2 = softwareSystem "System 2" {
            container3 = container "Container 1"
            container4 = container "Container 2"
        }

        r1 = container3 -> container1 "3 -> 1"
        r2 = container4 -> container2 "4 -> 2"
    }   

    views {
        systemLandscape {
            include system1 system2
            exclude r1 r2
            autolayout
        }
        theme default
    }
}

Configuration

Lite 3088

Severity

Major

Priority

Medium

Resolution

I have no budget, please fix this for free

More information

No response

simonbrowndotje commented 1 year ago

This is now available in build 3099 of Structurizr Lite.

max-arshinov commented 1 year ago

Thank you @simonbrowndotje. I checked the latest version and it works now. However, I noticed something else: https://github.com/structurizr/dsl/issues/306. Sorry :)