search

structurizr / java-extensions

Structurizr for Java extensions
Apache License 2.0
39 stars 23 forks source link

Styling of external systems in system context diagram not correct #64

Closed MTomBosch closed 2 years ago

MTomBosch commented 2 years ago

I have defined an enterprise with enterprise internal and enterprise external systems. In the system landscape view it is wanted that enterprise external systems/persons are also styled as external elements (= in gray). This happens properly when doing an export in c4plantuml format using the cli tool.

But in a System Context diagram the external systems (compared to the system in context) that are in the enterprise are not styled like external systems. Only the enterprise external systems are marked as external. This makes it quite hard in the diagram to focus on the system in context since you first have to go over all blue shapes.

My expectation would be that ALL external systems are styled like external systems and not just the ones external to the enterprise. Or the system in context must be styled in a way that the eyes can see it immediately.

simonbrowndotje commented 2 years ago

The C4PlantUMLExporter checks the location property of the element to determine whether to use the System or System_Ext macro. This is done irrespective of the diagram type, ensuring that elements are consistently styled for system landscape and system context diagrams. For more control, I'd recommend creating your own fork of the C4PlantUMLExporter to override this behaviour.

MTomBosch commented 2 years ago

Ok. That makes sense. Will close this issue then.

Thank you