structurizr / java-extensions

Structurizr for Java extensions
Apache License 2.0
39 stars 23 forks source link

Extensions failing when using core 1.21 or later #71

Open carljonescf opened 1 year ago

carljonescf commented 1 year ago

Description

I'm using the Spring extension and the annotations support with Structurizr for Java. All is good with core/client versions up to 1.20.x, but 1.21 introduces a bug with this stack trace.

java.lang.NoSuchMethodError: 'com.structurizr.model.Component com.structurizr.model.Container.addComponent(java.lang.String, java.lang.String, java.lang.String, java.lang.String)' at com.structurizr.analysis.AbstractComponentFinderStrategy.addComponent(AbstractComponentFinderStrategy.java:211) at com.structurizr.analysis.AbstractComponentFinderStrategy.findClassesWithAnnotation(AbstractComponentFinderStrategy.java:181) at com.structurizr.analysis.SpringRestControllerComponentFinderStrategy.doFindComponents(SpringRestControllerComponentFinderStrategy.java:18) at com.structurizr.analysis.AbstractComponentFinderStrategy.findComponents(AbstractComponentFinderStrategy.java:57) at com.structurizr.analysis.SpringComponentFinderStrategy.doFindComponents(SpringComponentFinderStrategy.java:62) at com.structurizr.analysis.AbstractComponentFinderStrategy.findComponents(AbstractComponentFinderStrategy.java:57) at com.structurizr.analysis.ComponentFinder.findComponents(ComponentFinder.java:77)

I notice that a breaking change is noted on 1.21.

For my purposes, 1.20.x is fine, but just thought I should alert you to this.

Steps to reproduce

Write Java code that uses the Spring Component Finder.

Expect the components to be found and added to the model.

Actual : stack trace above.

Screenshot

No response

Code sample

No response

Configuration

No response

Severity

Minor

Priority

Low

Resolution

I have no budget and there's no rush, please fix this for free

More information

No response

simonbrowndotje commented 1 year ago

See https://github.com/structurizr/java-extensions/discussions/69 ... the analysis library requires a big update I'm afraid.

carljonescf commented 1 year ago

Hi

That's a pity and slightly disappointing to read that it has little use.

I find it enlightening to give this to my students and show them just how much that can generate in 16 people-weeks. It opens up the discussion on imagining what bigger applications might look like after many months/years and (hopefully) makes the students realise the benefits of some planned design work.

Thanks Carl

From: Simon Brown @.> Sent: Friday, October 27, 2023 11:29 AM To: structurizr/java-extensions @.> Cc: Carl Jones @.>; Author @.> Subject: Re: [structurizr/java-extensions] Extensions failing when using core 1.21 or later (Issue #71)

External email to Cardiff University - Take care when replying/opening attachments or links. Nid ebost mewnol o Brifysgol Caerdydd yw hwn - Cymerwch ofal wrth ateb/agor atodiadau neu ddolenni.

See #69https://github.com/structurizr/java-extensions/discussions/69 ... the analysis library requires a big update I'm afraid.

- Reply to this email directly, view it on GitHubhttps://github.com/structurizr/java-extensions/issues/71#issuecomment-1782677702, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEGSJFLQXNSZVDGLC4JKV3TYBOEFVAVCNFSM6AAAAAA6SRWBKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBSGY3TONZQGI. You are receiving this because you authored the thread.Message ID: @.**@.>>