Fixes getWorkspaceIds when S3 return is too big

structurizr / onpremises

Structurizr on-premises installation

https://docs.structurizr.com/onpremises

MIT License

140 stars 54 forks source link

Closed iowaz closed 3 months ago

iowaz commented 5 months ago

AWS S3 API has a limit of maximum 1000 keys per response (reference: https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjects.html) - this breaks getWorkspaceIds when your have a lot of objects.

This pull request changes the way getWorkspaceIds method works when pulling objects from S3.

Fixes #108

iowaz commented 5 months ago

Hey @simonbrowndotje can you look at this? Thanks in advance <3

marcusalexandre commented 5 months ago

Good!

iowaz commented 4 months ago

Hey @simonbrowndotje can you review this pull request?

iowaz commented 3 months ago

Hey @simonbrowndotje good afternoon! Can you take a quick look at this? I'm afraid that eventually we will get a conflict 😅

simonbrowndotje commented 3 months ago

Thank you. :-)