structurizr / onpremises

Structurizr on-premises installation
https://docs.structurizr.com/onpremises
MIT License
117 stars 45 forks source link

Empty diagrams #75

Closed eric-panier-opalrt closed 7 months ago

eric-panier-opalrt commented 9 months ago

Description

Hi,

When we load the workspaces/veniam_workspace.dsl in the attached zip file "empty_diagrams_bug.zip" on Structurizr onpremises version: 3124 and 3194 (Latest). Structurizr seems to work well but when we click on a diagram we get a empty page. Structurizr seems to load the diagram but nothing appears.

If we edit the workspaces/veniam_workspace.dsl file and comment any line 11, 12, 13 or 14. Everything works well.

We tried to identify the views producing the issue but we haven’t been able to find the conditions to produce it. We thought about deployment views or dynamic views but we are able to load correctly all of them separately but not all together.

empty_diagrams_bug.zip

Thanks for your help and sorry to not be able to help you more to identify the conditions of this bug.

Strange things is that it works well with Structurizr Lite 3124 and Latest.

This is a blocker for our project, thanks, Best regards.

Eric PANIER

OPAL-RT TECHNOLOGIES

Steps to reproduce

If we edit the workspaces/veniam_workspace.dsl file and comment any line 11, 12, 13 or 14. Everything works well.

Screenshot

image

Code sample

No response

Configuration

structurizr onpremises build 3124 and 3194 (Latest)

Severity

Major

Priority

High

Resolution

I have no budget and there's no rush, please fix this for free

More information

No response

eric-panier-opalrt commented 8 months ago

Hi @simonbrowndotje,

Did you have time to check this issue please ?

Thanks for your time. Best regards. Eric PANIER OPAL-RT TECHNOLOGIES

simonbrowndotje commented 8 months ago

Did you have time to check this issue please ?

I'm busy travelling around running workshops/speaking at conferences/etc during October/November so I have limited time for free support at the moment I'm afraid. I took a quick look at the ZIP file, and you seem to have a lot of views - perhaps your issue is already solved in build 3203+?

eric-panier-opalrt commented 8 months ago

Thanks @simonbrowndotje,

I understand. I will try the latest build to check and will confirm if it is solved or not...

Have good conferences and workshops :-) Eric

opalrt commented 8 months ago

Hi @simonbrowndotje, I did a mistake when I created this issue. I created it with my account eric-panier-opalrt. But I should have create it with our company account (the one I'm using to write this comment) to be sure this issue will be considered in our official support. Because we pay for the support. Is it possible to move it or do I need to recreate it ?

Thanks. Best regards. Eric PANIER OPAL-RT TECHNOLOGIES

simonbrowndotje commented 8 months ago

No problem, feel free to e-mail help@structurizr.com with details of your on-premises support contract. 👍

simonbrowndotje commented 8 months ago

I've just tried your workspace with structurizr/onpremises:3208 (Docker image), pushed via v1.34.0 of the Structurizr CLI and all diagrams seem to render for me. Did you try upgrading everything?

opalrt commented 8 months ago

Thanks for the info. I did not test latest version yet, I am waiting my IT service. I will let you know when it is done...

opalrt commented 8 months ago

Hi @simonbrowndotje,

We upgraded to the Build 3208 onpremise. But we get new bugs. image

The diagrams are not all visibles (very long when we click on thumbnails) and the layout seems not applied (overlaps). It seems all elements have the same position. image image image

Everything works well when I put only !include ../build/veniam_views in the workspace (less diagrams). Thanks for your help. Eric.

simonbrowndotje commented 8 months ago

Is this the prebuilt Docker image or are you using the .war file? And have you tried using private browsing/another web browser/clearing your browser cache? Any errors in the JavaScript console or the server logs?

I would be tempted to install a basic on-premises installation on your local computer to ascertain whether this is a problem with something in your environment.

opalrt commented 8 months ago

Thanks for clues ! I see this error in javascript console, it seems it is a problem with the payload size : (Payload Too Large) structurizr.opal-rt.com-1699458123656.log And as you can see in the log, there is this error: Automatic layout failed First time I load a diagram, there are a lot of error about thumbnails error 404 but I guess it is normal because I did not clicked on them to build them.

simonbrowndotje commented 8 months ago

I'm assuming that you're not using the prebuilt Docker image then? If so, it's a relatively straightforward fix; see maxPostSize at https://tomcat.apache.org/tomcat-9.0-doc/config/http.html

Related: https://github.com/structurizr/onpremises/issues/56 (it may be something like nginx rather than Tomcat)

opalrt commented 8 months ago

Thanks, I'am contacting my IT-support to check. I will comeback when I have an answer...

opalrt commented 7 months ago

Hi @simonbrowndotje, we confirmed it was nginx and max-payload-size configuration. we change from 1M to 64M. Everything work well. We can can close this issue please. (I don't know how :-). Thanks for your time. Regards. Eric PANIER