search

structurizr / ui

UI code for Structurizr Lite, on-premises, and cloud service.
https://docs.structurizr.com/ui
MIT License
43 stars 27 forks source link

New shapes #3

Open RVR06 opened 1 year ago

RVR06 commented 1 year ago

Shape library will benefit some addition. Obvious ones would be desktop app & cli to mirror what we have for web browser & mobile, and better identify entry points in such use cases. I give a try and end up with this one for desktop:

image

Don't pay attention to the color, they are of course bound to matching properties.

Is this something we could submit PR for?

simonbrowndotje commented 1 year ago

The code in this repo isn't yet running in the on-premises installation and cloud service, so I'd rather not add any new features quite yet ... but leave it with me and I will add desktop app and cli/terminal style shapes for you. 👍

simonbrowndotje commented 1 year ago

A window shape is now available.

Screenshot 2023-02-20 at 07 25 13

For the other shape (terminal, cli ... name to be decided), I was thinking of putting a > or > _ symbol in the lower left of the same shape. Thoughts?

RVR06 commented 1 year ago

Perfect. I was thinking about having >_ in place of 3 buttons for terminal, to end up with 3 different shapes. Kind of: image

frank-zwarthoed commented 9 months ago

It would also be helpful to enable use of the octagon shape in styling of elements.

In my use case it would help to create views to describe how the ideas of cell based architecture can be applied (https://github.com/wso2/reference-architecture/blob/master/reference-architecture-cell-based.md).

The octagon shape seems to be available in the bootstrap icon library, so implementation in structurizr-ui seems doable. It would however also mean a (minor) modification of struturizr-dsl (and thus structurizr-java) in order to define the octagon shape in the styling section. The modification seems to also require updates to other repositories than structurizr-ui.

Happy to help, but I may need some guidance on how to introduce the required modifications. I managed to modify and unit-test the libraries mentioned above using a containerized JDK environment. But I haven't been able to demonstrate the result as I'm struggling on how to use the updated dependencies during the build of structurizr-lite.