search

structurizr / ui

UI code for Structurizr Lite, on-premises, and cloud service.
https://docs.structurizr.com/ui
MIT License
38 stars 22 forks source link

Export diagrams generates broken diagrams #39

Closed gravis closed 7 months ago

gravis commented 7 months ago

Description

When using the Export to PNG or Export to SVG feature, diagrams seem broken compared to the rendered version. For example, when using the Internet Banking System example, the System Context export looks like this:

structurizr-1-SystemContext

I also noticed some issues with the puppeteer script which generates several times the same diagram instead of the right ones (System Context is actually the System Landscape for example).

Steps to reproduce

  1. curl -o workspace.dsl https://raw.githubusercontent.com/structurizr/dsl/a97141682dffd8b5104cedd7155e1a87be2d5fb6/src/test/dsl/big-bank-plc.dsl
  2. docker run -it --rm -p 8080:8080 -v $PWD:/usr/local/structurizr -e STRUCTURIZR_WORKSPACE_PATH=. structurizr/lite
  3. Export to PNG

Screenshot

Screenshot 2023-11-08 at 23 58 51

Code sample

No response

Configuration

Using structurizr/lite:latest Docker image (Digest: sha256:5012d4f04198afd22cda992660ce12873bd7fc29fcc124d00462c2e6ca8e3bdb)

Severity

Major

Priority

I have no budget and there's no rush, please fix this for free

More information

No response

gravis commented 7 months ago

By the way, I'm using Chrome 119.0.6045.105 for the manual exports.

simonbrowndotje commented 7 months ago

Fixed by https://github.com/structurizr/ui/commit/2a06c25b6579ef7efaa14c241601197ee55d8780