strudel-science / strudel-kit

Frontend React templates for implementing scientific UIs with the STRUDEL design system.
https://strudel.science/strudel-kit/docs
Other
8 stars 3 forks source link

strudel --version does not work #26

Closed dangunter closed 7 months ago

dangunter commented 8 months ago

When I try strudel --version on the current version from GH main, I get:

❯ strudel --version
╭─────────────────────────────── Traceback (most recent call last) ────────────────────────────────╮
│ in _run_module_as_main:198                                                                       │
│ ╭─────────────────────────────────────────── locals ───────────────────────────────────────────╮ │
│ │   alter_argv = False                                                                         │ │
│ │         code = <code object <module> at 0x0000028C6BCB0030, file                             │ │
│ │                "C:\Users\dkgun\miniconda3\envs\strudel-kit-learn\Scripts\strudel.exe\__main… │ │
│ │                line 1>                                                                       │ │
│ │ main_globals = {                                                                             │ │
│ │                │   '__name__': '__main__',                                                   │ │
│ │                │   '__doc__': None,                                                          │ │
│ │                │   '__package__': '',                                                        │ │
│ │                │   '__loader__': <zipimporter object                                         │ │
│ │                "C:\Users\dkgun\miniconda3\envs\strudel-kit-learn\Scripts\strudel.exe\">,     │ │
│ │                │   '__spec__': ModuleSpec(name='__main__', loader=<zipimporter object        │ │
│ │                "C:\Users\dkgun\miniconda3\envs\strudel-kit-learn\Scripts\strudel.exe\">,     │ │
│ │                origin='C:\\Users\\dkgun\\miniconda3\\envs\\strudel-kit-learn\\Scripts\\stru… │ │
│ │                │   '__annotations__': {},                                                    │ │
│ │                │   '__builtins__': <module 'builtins' (built-in)>,                           │ │
│ │                │   '__file__':                                                               │ │
│ │                'C:\\Users\\dkgun\\miniconda3\\envs\\strudel-kit-learn\\Scripts\\strudel.exe… │ │
│ │                │   '__cached__':                                                             │ │
│ │                'C:\\Users\\dkgun\\miniconda3\\envs\\strudel-kit-learn\\Scripts\\strudel.exe… │ │
│ │                │   're': <module 're' from                                                   │ │
│ │                'C:\\Users\\dkgun\\miniconda3\\envs\\strudel-kit-learn\\Lib\\re\\__init__.py… │ │
│ │                │   ... +2                                                                    │ │
│ │                }                                                                             │ │
│ │     mod_name = '__main__'                                                                    │ │
│ │     mod_spec = ModuleSpec(name='__main__', loader=<zipimporter object                        │ │
│ │                "C:\Users\dkgun\miniconda3\envs\strudel-kit-learn\Scripts\strudel.exe\">,     │ │
│ │                origin='C:\\Users\\dkgun\\miniconda3\\envs\\strudel-kit-learn\\Scripts\\stru… │ │
│ ╰──────────────────────────────────────────────────────────────────────────────────────────────╯ │
│ in _run_code:88                                                                                  │
│ ╭─────────────────────────────────────────── locals ───────────────────────────────────────────╮ │
│ │       cached = 'C:\\Users\\dkgun\\miniconda3\\envs\\strudel-kit-learn\\Scripts\\strudel.exe… │ │
│ │         code = <code object <module> at 0x0000028C6BCB0030, file                             │ │
│ │                "C:\Users\dkgun\miniconda3\envs\strudel-kit-learn\Scripts\strudel.exe\__main… │ │
│ │                line 1>                                                                       │ │
│ │        fname = 'C:\\Users\\dkgun\\miniconda3\\envs\\strudel-kit-learn\\Scripts\\strudel.exe… │ │
│ │ init_globals = None                                                                          │ │
│ │       loader = <zipimporter object                                                           │ │
│ │                "C:\Users\dkgun\miniconda3\envs\strudel-kit-learn\Scripts\strudel.exe\">      │ │
│ │     mod_name = '__main__'                                                                    │ │
│ │     mod_spec = ModuleSpec(name='__main__', loader=<zipimporter object                        │ │
│ │                "C:\Users\dkgun\miniconda3\envs\strudel-kit-learn\Scripts\strudel.exe\">,     │ │
│ │                origin='C:\\Users\\dkgun\\miniconda3\\envs\\strudel-kit-learn\\Scripts\\stru… │ │
│ │     pkg_name = ''                                                                            │ │
│ │  run_globals = {                                                                             │ │
│ │                │   '__name__': '__main__',                                                   │ │
│ │                │   '__doc__': None,                                                          │ │
│ │                │   '__package__': '',                                                        │ │
│ │                │   '__loader__': <zipimporter object                                         │ │
│ │                "C:\Users\dkgun\miniconda3\envs\strudel-kit-learn\Scripts\strudel.exe\">,     │ │
│ │                │   '__spec__': ModuleSpec(name='__main__', loader=<zipimporter object        │ │
│ │                "C:\Users\dkgun\miniconda3\envs\strudel-kit-learn\Scripts\strudel.exe\">,     │ │
│ │                origin='C:\\Users\\dkgun\\miniconda3\\envs\\strudel-kit-learn\\Scripts\\stru… │ │
│ │                │   '__annotations__': {},                                                    │ │
│ │                │   '__builtins__': <module 'builtins' (built-in)>,                           │ │
│ │                │   '__file__':                                                               │ │
│ │                'C:\\Users\\dkgun\\miniconda3\\envs\\strudel-kit-learn\\Scripts\\strudel.exe… │ │
│ │                │   '__cached__':                                                             │ │
│ │                'C:\\Users\\dkgun\\miniconda3\\envs\\strudel-kit-learn\\Scripts\\strudel.exe… │ │
│ │                │   're': <module 're' from                                                   │ │
│ │                'C:\\Users\\dkgun\\miniconda3\\envs\\strudel-kit-learn\\Lib\\re\\__init__.py… │ │
│ │                │   ... +2                                                                    │ │
│ │                }                                                                             │ │
│ │  script_name = None                                                                          │ │
│ ╰──────────────────────────────────────────────────────────────────────────────────────────────╯ │
│                                                                                                  │
│ in <module>:7                                                                                    │
│                                                                                                  │
│ C:\Users\dkgun\miniconda3\envs\strudel-kit-learn\Lib\site-packages\typer\main.py:328 in __call__ │
│                                                                                                  │
│ C:\Users\dkgun\miniconda3\envs\strudel-kit-learn\Lib\site-packages\typer\main.py:311 in __call__ │
│                                                                                                  │
│ C:\Users\dkgun\miniconda3\envs\strudel-kit-learn\Lib\site-packages\click\core.py:1157 in         │
│ __call__                                                                                         │
│                                                                                                  │
│ C:\Users\dkgun\miniconda3\envs\strudel-kit-learn\Lib\site-packages\typer\core.py:778 in main     │
│                                                                                                  │
│ C:\Users\dkgun\miniconda3\envs\strudel-kit-learn\Lib\site-packages\typer\core.py:215 in _main    │
│                                                                                                  │
│ C:\Users\dkgun\miniconda3\envs\strudel-kit-learn\Lib\site-packages\click\core.py:943 in          │
│ make_context                                                                                     │
│                                                                                                  │
│ C:\Users\dkgun\miniconda3\envs\strudel-kit-learn\Lib\site-packages\click\core.py:1644 in         │
│ parse_args                                                                                       │
│                                                                                                  │
│ C:\Users\dkgun\miniconda3\envs\strudel-kit-learn\Lib\site-packages\click\core.py:1408 in         │
│ parse_args                                                                                       │
│                                                                                                  │
│ C:\Users\dkgun\miniconda3\envs\strudel-kit-learn\Lib\site-packages\click\core.py:2400 in         │
│ handle_parse_result                                                                              │
│                                                                                                  │
│ C:\Users\dkgun\miniconda3\envs\strudel-kit-learn\Lib\site-packages\click\core.py:2362 in         │
│ process_value                                                                                    │
│                                                                                                  │
│ C:\Users\dkgun\miniconda3\envs\strudel-kit-learn\Lib\site-packages\typer\main.py:994 in wrapper  │
│                                                                                                  │
│ C:\Users\dkgun\src\strudel-project\strudel-kit\strudel-cli\src\strudel\callbacks.py:39 in        │
│ version_callback                                                                                 │
│                                                                                                  │
│   36                                                                                             │
│   37 def version_callback(value: bool):                                                          │
│   38 │   if value:                                                                               │
│ ❱ 39 │   │   print(f"strudel-cli {__version__}")                                                 │
│   40 │   │   raise typer.Exit()                                                                  │
│   41                                                                                             │
│   42                                                                                             │
│                                                                                                  │
│ ╭─── locals ───╮                                                                                 │
│ │ value = True │                                                                                 │
│ ╰──────────────╯                                                                                 │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
NameError: name '__version__' is not defined
(strudel-kit-learn) dkgun ~\src\strudel-project\strudel-kit\docs dstut ≡*?4  1  628ms
❯
codytodonnell commented 7 months ago

Fixed by https://github.com/strudel-science/strudel-kit/commit/47b2f6a9b8e23bea0f49ee3ba184af937e2ebdfe