strukturag / libde265

Open h.265 video codec implementation.
Other
1.7k stars 456 forks source link

Deprecated configure macros #356

Open fancycode opened 1 year ago

fancycode commented 1 year ago

Building on Debian sid complains about various deprecated macros in configure.ac:

libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
configure.ac:24: warning: The macro `AC_CANONICAL_SYSTEM' is obsolete.
configure.ac:24: You should run autoupdate.
./lib/autoconf/general.m4:2081: AC_CANONICAL_SYSTEM is expanded from...
configure.ac:24: the top level
configure.ac:59: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:59: You should run autoupdate.
./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from...
lib/m4sugar/m4sh.m4:692: _AS_IF_ELSE is expanded from...
lib/m4sugar/m4sh.m4:699: AS_IF is expanded from...
./lib/autoconf/general.m4:2249: AC_CACHE_VAL is expanded from...
m4/visibility.m4:23: gl_VISIBILITY is expanded from...
configure.ac:59: the top level
configure.ac:110: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:110: You should run autoupdate.
./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from...
configure.ac:110: the top level
configure.ac:123: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:123: You should run autoupdate.
./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from...
configure.ac:123: the top level
configure.ac:132: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:132: You should run autoupdate.
./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from...
configure.ac:132: the top level
configure.ac:148: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:148: You should run autoupdate.
./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from...
configure.ac:148: the top level
configure.ac:166: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:166: You should run autoupdate.
./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from...
configure.ac:166: the top level
configure.ac:31: installing './compile'
configure.ac:43: installing './missing'
farindk commented 12 months ago

Do we still need the configure script or can we switch to cmake as the only build environment?

farindk commented 9 months ago

@fancycode Any opinion on this?

farindk commented 9 months ago

The CI still uses the configure scripts.

farindk commented 8 months ago

TODO:

brad0 commented 6 months ago

Looking at switching to CMake from autoconf I noticed the list of installed tools has a bunch of missing stuff..

@@ -1,12 +1,3 @@
 @conflict libde265-1.0.5
-@bin bin/acceleration_speed
-@bin bin/bjoentegaard
-@bin bin/block-rate-estim
 @bin bin/dec265
-@bin bin/enc265
-@bin bin/gen-enc-table
-@bin bin/hdrcopy
-@bin bin/rd-curves
-@bin bin/sherlock265
 @comment @bin bin/tests
-@bin bin/yuv-distortion
farindk commented 6 months ago

This is mostly ok. Most of those were small test programs for development. For some I even forgot what they do.

The only thing that might be some fun to look at is sherlock265. The other ones should either be dropped completely or hidden behind a default-off flag.

brad0 commented 6 months ago

Ok, I noticed sherlock265 was mentioned. I figured I'd mention the rest incase they were useful at all. I have no idea what some of those do.